Duration ignored in YAML config

[wulftone]

In ~/.config/aws_okta_keyman.yml I have specified duration: 43200. This value is ignored in aws_okta_keyman v0.8.5. It works if I specify it on the CLI with --duration 43200.

$ cat ~/.config/aws_okta_keyman.yml | grep duration
duration: 43200

$ aws_okta_keyman --appid xxx
12:53:32 (INFO) AWS Okta Keyman 🔐 v0.8.5
12:53:37 (INFO) Successfully authed xxx
12:53:38 (INFO) Getting SAML Assertion from xxx
12:53:39 (INFO) Starting AWS session for us-east-1
12:53:39 (INFO) Assuming role: arn:aws:iam::123:role/xxx
12:53:39 (INFO) Wrote profile "default" to /home/xxx/.aws/credentials 💾
12:53:39 (INFO) Current time is 2020-10-07 19:53:39.483773
12:53:39 (INFO) Session expires at 2020-10-07 20:53:39+00:00 ⏳
12:53:39 (INFO) All done! 👍

$ aws_okta_keyman --appid xxx --duration 43200
12:53:49 (INFO) AWS Okta Keyman 🔐 v0.8.5
12:53:53 (INFO) Successfully authed xxx
12:53:53 (INFO) Getting SAML Assertion from xxx
12:53:54 (INFO) Starting AWS session for us-east-1
12:53:54 (INFO) Assuming role: arn:aws:iam::123:role/xxx
12:53:54 (INFO) Wrote profile "default" to /home/xxx/.aws/credentials 💾
12:53:54 (INFO) Current time is 2020-10-07 19:53:54.977365
12:53:54 (INFO) Session expires at 2020-10-08 07:53:54+00:00 ⏳
12:53:54 (INFO) All done! 👍

[nathan-v]

@wulftone Sorry for the delay here; I've been meaning to look into this but changed jobs and the new one has been keeping me extremely busy.

[IsaacPham]

The issue is that parse_config will "Only overwrite None not args" and duration arg has a default value of 3600 so it won't be overwritten. I've been working around this by removing the default from that arg in config.py, but not sure how you want to handle this.

[nathan-v]

This will be fixed in the next update.

[nathan-v]

Done in #98.