-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsafe JavaScript attempt #167
Comments
Interesting. I just checked master and ran the tests fine and I have 1.9.8 installed too. Thats not to say that this is not a problem, but I did not see it yet. Looking for others to chime in. |
I also tried running my own tests using |
I'm also running into this issue, and here's someone else experiencing it as well via the gulp plugin. |
I had this issue as well, but I resolved it by updating mocha.js to the latest version. |
I'm having the same issue. Also using gulp-mocha-phantomjs. |
Yes it is because of the above referenced phantomjs issue. I saw it while working on from what I've seen, forcing |
@nathanboktae I just tried to install |
Any progress on this? Not all my tests run due to this error. |
This is not an issue with I'm going to be focusing on v4 that will move to phantomjs 2, so this will be resolved then. For now, you can force using an older version of phantomjs via the |
Are you referring to forcing the npm package
Is there a workaround that will solve this until |
Correct I was mistaken. Install phantomjs 1.9.16 yourself then use the |
The npm package or the actual software? I tried that with the npm package, and I don't see a v1.9.16 of PhantomJS. I'll try building 1.9.7 from source and will report back. |
Alright, I built PhantomJS 1.9.7 from source by following these instructions, except instead of Then I changed the PhantomJS path in my mocha-phantomjs test command from This has fixed this issue for me. |
Ouch, there are built versions available for 1.9.7 FYI. |
Hmm, I didn't see any information about built older versions on the PhantomJS website, or through a quick google search. The only pre-built versions I could find were 1.9.0(via Oh well, it only took around 40-60 min to build and my work day was already over anyways. |
Broke our Travis. Why would you do this in minor version? My problem is that I dont even control that, as it gets required via grunt-mocha-phantomjs intermediate |
Right it shouldn't have been. My bad I'll revert the dependency version and republish, then publish a minor bump. And in v4 it'll be a direct dependency avoiding the problem. |
This change has caused an issue with the gulp-mocha-phantomjs module. I'm not entirely sure how the dependency versions are working, but gulp-mocha-phantomjs is allowing phantomjs 1.9.17, where this change is only allowing up to 1.9.15. This results in the following error:
The workaround is to explicitly reference phantomjs 1.9.15 in my package.json file. |
Hey,
I've been trying to get this project running on my local machine. But every time I run the test suite I'm greeted by the following error:
It might be related to 1.9.8 release of phantomjs: ariya/phantomjs#12697
The text was updated successfully, but these errors were encountered: