Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9.0 had a breaking change #80

Open
ljharb opened this issue Apr 21, 2020 · 2 comments
Open

v1.9.0 had a breaking change #80

ljharb opened this issue Apr 21, 2020 · 2 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Apr 21, 2020

By adding https-proxy-agent as a dep in ddf708b and 8579b31 - which requires node 4 - v1.9+ of install-peerdeps (which enzyme-adapter-react-helper uses) stopped working in node < 4 (i use it in node 0.10 and 0.12)

It would be great if a backport of v1 could be landed that fixes this, so I don't have to pin enzyme to v1.8 forever :-/ (see https://travis-ci.org/github/airbnb/prop-types/jobs/677498727 for the particular failure)

ljharb added a commit to ljharb/prop-types-tools that referenced this issue Apr 21, 2020
 - note: `install-peerdeps` is pinned to `~1.9` for now, due to nathanhleung/install-peerdeps#80
@ljharb ljharb changed the title v1.10.0 had a breaking change v1.9.0 had a breaking change Apr 21, 2020
ljharb added a commit to enzymejs/enzyme that referenced this issue Apr 21, 2020
ljharb added a commit to enzymejs/enzyme that referenced this issue Apr 21, 2020
 - [Fix] pin `install-peerdeps` to `~1.8`, due to nathanhleung/install-peerdeps#80
 - [meta] Replace airbnb.io with enzymejs.github.io; update repo URLs
 - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `eslint-plugin-import`, `in-publish`, `rimraf`
 - [Tests] [Dev Deps] Update to babel 7, use `babel-eslint`
@nathanhleung
Copy link
Owner

Sorry about this, I didn't realize. Is there any solution other than to use a lower version of https-proxy-agent that supports Node 0.12?

@ljharb
Copy link
Collaborator Author

ljharb commented May 11, 2020

I'm not really sure. Based on some of the newer PRs, shelling out to npm is a better solution than using a proxy option anyways - if #85 lands, that might restore old node support by removing http-proxy-agent entirely, but that'd also be a breaking change, so i'm not sure what the best solution is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants