fix: add .cmd to commands on windows

[nathanhleung]

This PR hopefully resolves #123. Here is what I think is going on:

1. Before PR use package manager to get info #85, which constitutes the main set of changes in v3.0.0, spawnCommand (a thin install-peerdeps-specific wrapper around child_process.spawn to promisify it) was called only in the install step (the call was something like spawnCommand("npm", ["install", "eslint-config-airbnb", ...restOfPeerdeps]).
2. The changes in use package manager to get info #85 introduced a second call to spawnCommand, to get package info directly from the package manager (through some code along the lines of spawnCommand("npm", ["info", "eslint-config-airbnb"]).
3. There was some special handling in the install step code, outside of spawnCommand, to preprocess the first argument to spawnCommand on Windows due to child_process.spawn does not work with npm run scripts on windows. nodejs/node#3675. Namely, the call on Windows would be changed to something like spawnCommand("npm.cmd", ["install", "eslint-config-airbnb"]) (note the .cmd suffix added to the first argument).
4. However, this special first argument handling was not copied to the package info retrieval code in use package manager to get info #85, which I think is what led to ERR spawn npm ENOENT #123 and breakage in v3.0.0 being reported on Windows.
5. This PR moves the special first argument handling inside of spawnCommand, automatically adding the .cmd suffix if it's not already present if it detects the tool running on Windows, which hopefully fixes ERR spawn npm ENOENT #123 and prevents a bug like this from happening again in the future.

[ljharb]

super gross hack, but this is a cleaner way to do an existing hack, so, nice :-)

[karlhorky]

Ah right, the .cmd extension on Windows - I read of that in my research before I found #123 ! Sounds promising - @thomalexg and I will take a look tomorrow.

[karlhorky]

@nathanhleung what do you think about adding Windows end-to-end tests to install-peerdeps? To catch any errors like this in the future? GitHub Actions and seemingly also Travis CI have the ability to run on Windows...

[ljharb]

travis-ci is slow and dying; i'd suggest github actions. I can convert the existing tests to github actions if @nathanhleung is OK with that; windows tests can go in separately/in parallel as a separate workflow.

[karlhorky]

Cool, if this is the way to go, maybe that could be done with a matrix - here's our approach for Preflight: https://github.com/upleveled/preflight/blob/main/.github/workflows/build-lint-test.yml#L7-L10

[nathanhleung]

@nathanhleung what do you think about adding Windows end-to-end tests to install-peerdeps? To catch any errors like this in the future? GitHub Actions and seemingly also Travis CI have the ability to run on Windows...

I think that's a great idea — don't want to break this package for Windows users in the future if I don't have to.

travis-ci is slow and dying; i'd suggest github actions. I can convert the existing tests to github actions if @nathanhleung is OK with that; windows tests can go in separately/in parallel as a separate workflow.

It would be awesome if you could do that, thanks!

[karlhorky]

Hi @karlhorky, opened #124 which I think should fix but can't test on macOS. Could you git fetch and then git checkout nathanhleung-fix and let me know whether it works?

The branch is no longer throwing the ERR spawn npm ENOENT / ERR spawn yarn ENOENT errors:

$ git fetch
$ git checkout nathanhleung-fix
$ yarn build && node . --yarn --dev @upleveled/eslint-config-upleveled && git reset --hard HEAD
yarn run v1.22.5
$ npm run clean
> install-peerdeps@3.0.0 clean
> rimraf lib
$ babel src --out-dir lib --ignore *.test.js
Successfully compiled 9 files with Babel (1411ms).
✨  Done in 3.14s.
install-peerdeps v3.0.0
Installing peerdeps for @upleveled/eslint-config-upleveled@latest.
yarn add @upleveled/eslint-config-upleveled@1.5.6 eslint-config-react-app@6.0.0 eslint-import-resolver-typescript@2.3.0 eslint-plugin-cypress@2.11.2 eslint-plugin-unicorn@26.0.1 typescript@4.1.3 --dev
SUCCESS @upleveled/eslint-config-upleveled
  and its peerDeps were installed successfully.
HEAD is now at 59c129e build: remove extraneous dependencies. resolves #115

Seems good to go! 🛳

[CoachRDeveloper]

Confirmed that it works on Windows. Please complete this pull request.

[nathanhleung]

Hi @karlhorky, opened #124 which I think should fix but can't test on macOS. Could you git fetch and then git checkout nathanhleung-fix and let me know whether it works?

The branch is no longer throwing the ERR spawn npm ENOENT / ERR spawn yarn ENOENT errors:

$ git fetch
$ git checkout nathanhleung-fix
$ yarn build && node . --yarn --dev @upleveled/eslint-config-upleveled && git reset --hard HEAD
yarn run v1.22.5
$ npm run clean
> install-peerdeps@3.0.0 clean
> rimraf lib
$ babel src --out-dir lib --ignore *.test.js
Successfully compiled 9 files with Babel (1411ms).
✨  Done in 3.14s.
install-peerdeps v3.0.0
Installing peerdeps for @upleveled/eslint-config-upleveled@latest.
yarn add @upleveled/eslint-config-upleveled@1.5.6 eslint-config-react-app@6.0.0 eslint-import-resolver-typescript@2.3.0 eslint-plugin-cypress@2.11.2 eslint-plugin-unicorn@26.0.1 typescript@4.1.3 --dev
SUCCESS @upleveled/eslint-config-upleveled
  and its peerDeps were installed successfully.
HEAD is now at 59c129e build: remove extraneous dependencies. resolves #115

Seems good to go! 🛳

Great! I'll cut 3.0.1 and push to NPM