Skip to content

Commit

Permalink
Re-enable node-cli tests in CI and fix them (paritytech#14093)
Browse files Browse the repository at this point in the history
With the recent change of re-running flaky tests this should be fine!
  • Loading branch information
bkchr authored and nathanwhit committed Jul 19, 2023
1 parent 37f251c commit e790e98
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions scripts/ci/gitlab/pipeline/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,13 @@ test-linux-stable:
- rusty-cachier snapshot create
# this job runs all tests in former runtime-benchmarks, frame-staking and wasmtime tests
# tests are partitioned by nextest and executed in parallel on $CI_NODE_TOTAL runners
# node-cli is excluded until https://github.com/paritytech/substrate/issues/11321 fixed
- echo "Node index - ${CI_NODE_INDEX}. Total amount - ${CI_NODE_TOTAL}"
- time cargo nextest run --workspace
--locked
--release
--verbose
--features runtime-benchmarks
--manifest-path ./bin/node/cli/Cargo.toml
--exclude node-cli
--partition count:${CI_NODE_INDEX}/${CI_NODE_TOTAL}
# we need to update cache only from one job
- if [ ${CI_NODE_INDEX} == 1 ]; then rusty-cachier cache upload; fi
Expand Down
2 changes: 1 addition & 1 deletion test-utils/cli/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub fn start_node() -> Child {
Command::new(cargo_bin("substrate"))
.stdout(process::Stdio::piped())
.stderr(process::Stdio::piped())
.args(&["--dev", "--tmp", "--ws-port=45789", "--no-hardware-benchmarks"])
.args(&["--dev", "--tmp", "--rpc-port=45789", "--no-hardware-benchmarks"])
.spawn()
.unwrap()
}
Expand Down

0 comments on commit e790e98

Please sign in to comment.