Recycler view #153
Open
Recycler view #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # library/borealis.mk # library/include/borealis/platforms/switch/switch_platform.hpp
# Conflicts: # library/include/borealis/core/platform.hpp # library/include/borealis/platforms/glfw/glfw_platform.hpp # library/include/borealis/platforms/switch/switch_platform.hpp # library/include/borealis/views/view.hpp # library/lib/platforms/glfw/glfw_platform.cpp # library/lib/platforms/switch/switch_platform.cpp # library/lib/views/scrolling_frame.cpp # library/meson.build
# Conflicts: # library/include/borealis/core/application.hpp # library/include/borealis/platforms/switch/switch_input.hpp # library/lib/core/application.cpp # library/lib/platforms/glfw/glfw_input.cpp # library/lib/views/scrolling_frame.cpp # library/lib/views/view.cpp
# Conflicts: # library/include/borealis.hpp
|
Hey thanks a lot for that draft! You are right about the detached views changes, I should have done it like that since the beginning. Since this starts from your work on touch, I would prefer to finish reviewing and merging that first, then I'll come to this PR, does that sound good to you? |
|
Yes, I'm also thought about that, there is no need in reviewing same changes twice. Let's finish with touch, then come back here. |
|
I was honestly thinking about that. It doesn't make sense to have a PR that uses code from another PR that hasn't been merged yet. |
|
True, but it uses a lot of Point and Rect structs, which I added in Touch PR so I decided to do it like that. |
# Conflicts: # library/lib/views/scrolling_frame.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in progress of creating recycler view.
I've changed the behaviour of detached views a bit. If previously they were fully detached from parent's coordinate system, now they still attached to parent's origin, but free from Yoga's layout calculations, so detached origin can be used to modify view's local position inside it's parent. I changed it cause I need cells to be attached to scroll's contentBox, so it's scrolling position will reflect to cell's absolute position, but still need to have an ability to place cells manually. Also I can't think of why we could need to absolutely detach view from it's parent, I think the behaviour I've made could be much more useful than previous one. If you have any idea about that, I'll be glad to hear them.
That PR is still in progress, but I'd like you to know about it.