Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Image::setImageFromMem #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

FaultyPine
Copy link

Allows images to be set from raw data

Allows images to be set from raw data
Copy link
Owner

@natinusala natinusala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me

Do you think you could add a way to test / showcase this in the demo?

this->texture = nvgCreateImageMem(vg, 0, data, size);

if (this->texture == 0)
fatal("Cannot load image from mem!");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for an exclamation mark :p

@EmmmaTech
Copy link
Contributor

As natinusala said, you should really add an demonstration of this in the demo

@EmmmaTech
Copy link
Contributor

Otherwise, no other problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants