Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIND-81:Fix for deploy-docs.yml #12

Closed
wants to merge 1 commit into from
Closed

FIND-81:Fix for deploy-docs.yml #12

wants to merge 1 commit into from

Conversation

TNA-Allan
Copy link
Contributor

@TNA-Allan TNA-Allan commented Nov 25, 2024 •
edited
Loading

Pull Request

Ticket URL: https://national-archives.atlassian.net/browse/FIND-81

About these changes

Fix deploy issue in #5
https://github.com/nationalarchives/ds-search/actions/runs/12010473067/job/33477388480
Copied from https://github.com/nationalarchives/tna-frontend-docs/blob/main/requirements.txt

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

@TNA-Allan TNA-Allan marked this pull request as ready for review November 25, 2024 13:05
@ahosgood
Copy link
Member

Fixed in df0a69b

@ahosgood ahosgood closed this Nov 27, 2024
@TNA-Allan TNA-Allan deleted the fix/FIND-81-docs-publish branch November 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosgood ahosgood Awaiting requested review from ahosgood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TNA-Allan @ahosgood