Tdrd 475 document the backend flow of metadata upload #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJKing
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Thanks for documenting this. Some comments on the ADR.
In addition can you add the diagram to this MD document as per the othe diagrams, with a brief explanation of the it: https://github.com/nationalarchives/tdr-dev-documentation/blob/master/beta-architecture/beta-architecture.md
| @@ -0,0 +1,31 @@ | |||
| # 35. Metadata CSV Validation | |||
There was a problem hiding this comment.
Could you make this specific to the UTF-8 validation only.
TomJKing
reviewed
Oct 21, 2024
|
|
||
| ## Structure and integrity checks | ||
|
|
||
| 1. **Virus check**: All files uploaded to TDR are checked for viruses using the virus check lambda |
There was a problem hiding this comment.
Don't need to mention the virus check as this is only about the UTF-8 validation
architecture-decision-records/0035-metadata-csv-utf-8-file-validation.md
Show resolved
Hide resolved
architecture-decision-records/0035-metadata-csv-utf-8-file-validation.md
Show resolved
Hide resolved
| @@ -82,3 +82,8 @@ The reference generator service will be used to assign citeable references. | |||
| for this to be a developer task, even though eventually we might build an | |||
| admin UI or integrate with the planned catalogue API | |||
| * Data stored in the export bucket can be transferred to the preservation system | |||
|
|
|||
| ## Metadata Validation | |||
ian-hoyle
deleted the
TDRD-475-Document-the-backend-flow-of-Metadata-Upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an ADR to detail CSV file integrity validation