Remove CreatedBy tag

[suzannehamilton]

Remove global CreatedBy tag from every resource. This was intended to store the user who ran Terraform to create the resource, but it was actually updated every time we ran Terraform, causing a lot of churn and overwriting the original value.

We couldn't find a way to add the tag on resource creation and freeze it, so it seems better to remove it.

Terraform will eventually be run by a Terraform user in CI, so the CreatedBy tag wouldn't be so useful anyway.

[suzannehamilton]

Closing this while I try a different solution.

[suzannehamilton]

Reopening because I still couldn't find a clean solution.

You can prevent tag overwriting with:

lifecycle {
  ignore_changes = [
    tags["CreatedBy"]
  ]
}

but you have to remember to add it to every resource.

According to this Terraform issue, there might be a solution in later Terraform versions. For now it seems easier to get rid of this field and add it back in Beta if we really need it.

[TomJKing]

Looks fine