Skip to content

Commit

Permalink
Remove the separate global header package
Browse files Browse the repository at this point in the history
  • Loading branch information
ahosgood committed Sep 16, 2024
1 parent 73dc900 commit dfce28b
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 296 deletions.
32 changes: 0 additions & 32 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,43 +131,11 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

publish-npm-global-header:
runs-on: ubuntu-latest
needs:
- publish-npm
- version-check
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
registry-url: https://registry.npmjs.org/
scope: '@nationalarchives'
- name: Install dependencies
run: npm ci
- name: Build package
run: ./tasks/global-header/build-global-header-package.sh
- name: Check npm credentials
run: npm whoami
- name: Publish to npm
run: cd package-global-header && npm publish
- name: Rename package directory
run: mv package-global-header "tna-frontend-global-header-${{ needs.version-check.outputs.version }}"
- name: Compress package
run: zip -r "tna-frontend-global-header-${{ needs.version-check.outputs.version }}.zip" "tna-frontend-global-header-${{ needs.version-check.outputs.version }}"
- name: Upload the package to the GitHub release
run: gh release upload "v${{ needs.version-check.outputs.version }}" "tna-frontend-global-header-${{ needs.version-check.outputs.version }}.zip"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

notify-slack:
runs-on: ubuntu-latest
needs:
- version-check
- publish-npm-cookie-banner
- publish-npm-global-header
steps:
- uses: actions/checkout@v4
- name: Get the release notes
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Deprecated
### Removed

- Removed the separate [global header package](https://www.npmjs.com/package/@nationalarchives/frontend-global-header)

### Fixed

- Fixed colour of hovered buttons using the `<button>` element
Expand Down
9 changes: 3 additions & 6 deletions src/nationalarchives/global-header-package.scss
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,9 @@ hr {
text-decoration-thickness: 1.5px;

&,
&:link {
@include colour.colour-font("link", true);
}

&:link,
&:visited {
@include colour.colour-font("link-visited");
@include colour.colour-font("font-base", true);
}

&:hover,
Expand All @@ -305,7 +302,7 @@ hr {

&.tna-link--no-visited-state {
&:visited {
@include colour.colour-font("link");
@include colour.colour-font("font-base");
}
}
}
Expand Down
8 changes: 0 additions & 8 deletions tasks/global-header/build-global-header-package.sh

This file was deleted.

250 changes: 0 additions & 250 deletions tasks/global-header/generate-global-header-assets.js

This file was deleted.

0 comments on commit dfce28b

Please sign in to comment.