Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change arrow version #16

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Change arrow version #16

merged 1 commit into from
Apr 18, 2024

Conversation

SteampunkIslande
Copy link
Collaborator

Ooof, arrow2 to arrow-rs, with working tests !
That was way easier than I thought it would be, but there are still some issues here and there when working with real world data.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 56.13497% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 59.48%. Comparing base (d82e2df) to head (8a258e9).
Report is 1 commits behind head on dev.

Files Patch % Lines
src/columndata.rs 48.07% 81 Missing ⚠️
src/name2data.rs 23.52% 39 Missing ⚠️
src/record2chunk.rs 53.33% 7 Missing ⚠️
src/schema.rs 87.71% 7 Missing ⚠️
src/lib.rs 86.66% 4 Missing ⚠️
src/bin/vcf2parquet.rs 0.00% 3 Missing ⚠️
src/cli.rs 85.71% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #16      +/-   ##
==========================================
+ Coverage   51.11%   59.48%   +8.36%     
==========================================
  Files           7        8       +1     
  Lines         626      738     +112     
==========================================
+ Hits          320      439     +119     
+ Misses        306      299       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natir natir force-pushed the change_arrow_version branch from bed448f to a03a2d7 Compare April 8, 2024 13:12
@natir natir force-pushed the change_arrow_version branch from f1ad94e to 942da0b Compare April 18, 2024 14:12
- improve test coverage
- decorelate some code
- support differente type au parquet version
- remove support of boolean list
@natir natir force-pushed the change_arrow_version branch from 942da0b to 2d27692 Compare April 18, 2024 14:18
@natir natir merged commit c71dec9 into dev Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants