Resolve Warnings #54
Merged
Resolve Warnings #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build failure here is identical to the current failures on master. |
| @@ -94,17 +98,18 @@ public synchronized ClassDefiner getClassDefiner() { | |||
|
|
|||
| Method callbackMethod = runtime.getFastestCallbackMethod(callbackType); | |||
|
|
|||
| Class<?>[] parameterTypes = callbackMethod.getParameterTypes(); | |||
| // Never used. Side effects? | |||
There was a problem hiding this comment.
Can definitely drop this one, thanks :-)
|
This is awesome, thanks a lot @ctrimble ! Please tell me you didn't resolve all the warnings by hand, or I'm gonna owe you too many beers for your own health... |
|
@ochafik the import corrections were totally automated. The rest was mostly adding wildcard types and taking the default resolution action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a large number of the warnings found in
org.bridjand a few warnings in other classes. Minimal changes were made to the test suite, in an effort to reduce impact to those using the library.