Skip to content

Commit

Permalink
fix(android): build fix with pnpm
Browse files Browse the repository at this point in the history
  • Loading branch information
farfromrefug committed May 3, 2022
1 parent 5855383 commit 90b3a95
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/gesturehandler/platforms/android/include.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ dependencies {
implementation "androidx.annotation:annotation:1.1.0"
}
repositories {
def appDir = "$rootDir/../../.."
def widgetsDir = "$appDir/node_modules/@nativescript/core/platforms/android"
def appPackageJsonFile = file("$appDir/package.json")
def widgetsDir = "$USER_PROJECT_ROOT/node_modules/@nativescript/core/platforms/android"
def appPackageJsonFile = file("$USER_PROJECT_ROOT/package.json")
if (appPackageJsonFile.exists()) {
def appPackageJson = new JsonSlurper().parseText(appPackageJsonFile.text)
if (appPackageJson.dependencies['@akylas/nativescript'] != null) {
widgetsDir = "$appDir/node_modules/@akylas/nativescript/platforms/android"
widgetsDir = "$USER_PROJECT_ROOT/node_modules/@akylas/nativescript/platforms/android"
}
}
flatDir {
Expand Down

8 comments on commit 90b3a95

@fklingler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farfromrefug
I just installed this new version and got this error

A problem occurred evaluating root project 'gesturehandler'.

Could not get unknown property 'USER_PROJECT_ROOT' for repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.

I use yarn as package manager

@farfromrefug
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fklingler what s your cli version?

@fklingler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn v1.22.17
ns 8.1.5

On Windows, using Java JDK 13.0.1

@farfromrefug
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fklingler upgrade your cli it should be working after that

@fklingler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean nativescript or yarn?

@farfromrefug
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fklingler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks!

@fklingler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine now, thank you

Please sign in to comment.