Add option to use short names instead of FQDN #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/add-optional-fdqdn
branch
from
154ac5f to
23918e6
Compare
|
What is the next release this PR will be part of ? |
|
We will get this out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if cluster has custom domain name, users have to override
k8sClusterDomain: cluster.local.This is not very portable if you want to reuse the same config for different clusters.
Added optional (disabled by default) FQDN usage.
If
is set, NATS will use short DNS names (i.e.
nats-0.nats.default)EDIT: we could consider to use this option by default, though I didn't want to introduce such a change without knowing context.