Skip to content

Commit

Permalink
De-flake TestJetStreamClusterInterestLeakOnDisableJetStream, RAFT gro…
Browse files Browse the repository at this point in the history
…ups close asynchronously (#6096)

RAFT group's subs are closed asynchronously, so there could be some left
when checking right after calling `server.DisableJetStream()`.
Eventually all subs should be gone.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
  • Loading branch information
derekcollison authored Nov 10, 2024
2 parents 37d4461 + ad7ff86 commit dac61b6
Showing 1 changed file with 16 additions and 13 deletions.
29 changes: 16 additions & 13 deletions server/jetstream_cluster_3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3347,20 +3347,23 @@ func TestJetStreamClusterInterestLeakOnDisableJetStream(t *testing.T) {

server.DisableJetStream()

var sublist []*subscription
account.sl.localSubs(&sublist, false)

var danglingJSC, danglingRaft int
for _, sub := range sublist {
if strings.HasPrefix(string(sub.subject), "$JSC.") {
danglingJSC++
} else if strings.HasPrefix(string(sub.subject), "$NRG.") {
danglingRaft++
checkFor(t, 2*time.Second, 100*time.Millisecond, func() error {
var sublist []*subscription
account.sl.localSubs(&sublist, false)

var danglingJSC, danglingRaft int
for _, sub := range sublist {
if strings.HasPrefix(string(sub.subject), "$JSC.") {
danglingJSC++
} else if strings.HasPrefix(string(sub.subject), "$NRG.") {
danglingRaft++
}
}
}
if danglingJSC > 0 || danglingRaft > 0 {
t.Fatalf("unexpected dangling interests for JetStream assets after shutdown (%d $JSC, %d $NRG)", danglingJSC, danglingRaft)
}
if danglingJSC > 0 || danglingRaft > 0 {
return fmt.Errorf("unexpected dangling interests for JetStream assets after shutdown (%d $JSC, %d $NRG)", danglingJSC, danglingRaft)
}
return nil
})
}

func TestJetStreamClusterNoLeadersDuringLameDuck(t *testing.T) {
Expand Down

0 comments on commit dac61b6

Please sign in to comment.