Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for stream imports and leafnodes, fixes #1332 #1335

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

Resolves #1332

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a question about the test.

users: [
{user: bad, password: pwd}
]
exports: [{stream: "foo"}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it "fun" maybe you could have made the export "bar" and then publish on "bar" and make sure it is received (on "foo"). This will make sure that the LS+ is sent on "bar" and not ">" (or "foo"), no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, will do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean remap the foo on import with a prefix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be on prefix + "foo" for streams. But will add that to make sure we do prefix subj.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought that we were mapping.. for stream there is only prefix..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, test a service too?

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 84b634e into master Apr 10, 2020
@derekcollison derekcollison deleted the stream_bug branch April 10, 2020 18:19
@derekcollison
Copy link
Member Author

Just saw Matthias response and already merged. I think the RI fix covers services..

@matthiashanel
Copy link
Contributor

LGTM - to be sure, will try service with my setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent subscription forwarding behavior across accounts and leaf nodes
3 participants