Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Service across accounts and leaf nodes #1337

Merged
merged 2 commits into from
Apr 11, 2020
Merged

[FIXED] Service across accounts and leaf nodes #1337

merged 2 commits into from
Apr 11, 2020

Conversation

matthiashanel
Copy link
Contributor

Tests #1336

Signed-off-by: Matthias Hanel mh@synadia.com

@matthiashanel
Test of service across accounts and leaf node. Tests #1336
e8ce738 
Signed-off-by: Matthias Hanel <mh@synadia.com>
@derekcollison
Copy link
Member

So if we just designate B as a hub this works..

@derekcollison
Copy link
Member

I have located the conditional where we bail and do not send the interest. Like I said if we make B act as a hub (which IMO it is in this case) works fine as is.

@matthiashanel
Copy link
Contributor Author

I have located the conditional where we bail and do not send the interest. Like I said if we make B act as a hub (which IMO it is in this case) works fine as is.

Are you saying the direction in which the route is created matters to getting a response?

@derekcollison
Copy link
Member

ok I do think this case should still work without the hub designation for B and found a fix. Will update this PR.

@derekcollison
Fix for #1336
ef85a1b 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison
Copy link
Member

It can, that role is important to some interest propagation but in this case I believe it still should have worked as is and found why it was not. Its fixed.

derekcollison
derekcollison approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, but want a LGTM from @kozlovic

@kozlovic kozlovic changed the title Test of service across accounts and leaf node. [FIXED] Service across accounts and leaf nodes Apr 11, 2020
kozlovic
kozlovic approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2b1fe8f into master Apr 11, 2020
@derekcollison derekcollison deleted the service-account-leaf-test branch April 12, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiashanel @derekcollison @kozlovic