[FIXED] Unnecessary account reloads #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested changes
May 11, 2020
|
@kozlovic , incorporated your comments. added waiting for disconnect event to unit test and moved to single re-lock in configureAccounts. |
kozlovic
requested changes
May 12, 2020
Fixes #1372 by updating s.sys.account pointer. This issue also showed that accounts are unnecessarily reloaded. This happened because account imports were not copied and thus, deepEqual detected a difference were none was. This was addressed by making the copy less shallow. Furthermore did deepEqual detects a difference when it compared slices that were appended to while processing a map. This was fixed by sorting before comparison. Noticed that Account.clients stored an unnecessary pointer. Removed duplicated code in systemAccount. Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372 by updating s.sys.account pointer.
This issue also showed that accounts are unnecessarily reloaded.
This happened because account imports were not copied and thus,
deepEqual detected a difference were none was.
This was addressed by making the copy less shallow.
Furthermore did deepEqual detects a difference when it compared
slices that were appended to while processing a map.
This was fixed by sorting before comparison.
Noticed that Account.clients stored an unnecessary pointer.
Removed duplicated code in systemAccount.
Signed-off-by: Matthias Hanel mh@synadia.com
I did not outright eliminate sys.account pointer as we do not necessarily always have a name that is specified.