Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure jwt claim update does not wipe system imports #2450

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Make sure jwt claim update does not wipe system imports #2450

merged 1 commit into from
Aug 17, 2021

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

@derekcollison
Make sure jwt claim update does not wipe system imports
84ff537 
Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
ripienaar approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kozlovic
kozlovic approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (hopefully we are done with replacing "" with EMPTY ;-) )

@derekcollison derekcollison merged commit bf1c298 into main Aug 17, 2021
@derekcollison derekcollison deleted the acc-connz-op branch August 17, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

@kozlovic kozlovic kozlovic approved these changes

@matthiashanel matthiashanel Awaiting requested review from matthiashanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @ripienaar @kozlovic