[FIXED] Issue #2397 #2480
Merged
[FIXED] Issue #2397 #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we had partial state due to server failure or being shutdown ungracefully we could enter into a stream reset state. The stream reset state is harsh but worked, however there was a bug that would not restart consumers that were attached. Also if no state exists, or state was truncated, we can detect that and not go through a full reset. Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
approved these changes
Sep 1, 2021
kozlovic
approved these changes
Sep 1, 2021
|
I added a fix for the race condition. |
|
I will redo the race fix in a bit after another mtg. |
derekcollison
force-pushed
the
issue_2397
branch
from
3b5aa77 to
ba168dd
Compare
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
issue_2397
branch
from
3b89950 to
4d99aa9
Compare
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we had partial state due to server failure or being shutdown ungracefully we could enter into a stream reset state.
The stream reset state is harsh but worked, however there was a bug that would not restart consumers that were attached.
Also if no state exists, or state was truncated, we can detect that and not go through a full reset.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core