[IMPROVED] MQTT stream per session replaced with single stream #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the availability of a "max message per subject" for a given stream, it is possible to replace individual streams that were created per session with a single stream that gets all sessions as a single message per subject, which subject is composed of the session client ID hash. The first time the new stream is created for a given account, all existing MQTT session streams will be transferred to the new mux'ed MQTT session stream. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
commented
Sep 8, 2021
| @@ -200,6 +201,7 @@ func (c *cluster) shutdown() { | |||
| os.Remove(cf) | |||
| } | |||
| if sd != _EMPTY_ { | |||
| sd = strings.TrimSuffix(sd, JetStreamStoreDir) | |||
There was a problem hiding this comment.
@derekcollison I noticed that the temporary directory nats-server would still be filled with empty directory, such as jetstream12345678. Since it seems that under this directory, the server would actually create jetstream directory, this remove all would remove jetstream but leave the empty parent directory.
This change helps cleaning up, and seems that JetStream pass, but keep that in mind if later when writing a test in case this change has an effect (for instance if you were expecting only jetstream to be removed but not the parent dir, etc..).
kozlovic
commented
Sep 8, 2021
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the availability of a "max message per subject" for a given
stream, it is possible to replace individual streams that were
created per session with a single stream that gets all sessions
as a single message per subject, which subject is composed of
the session client ID hash.
The first time the new stream is created for a given account,
all existing MQTT session streams will be transferred to the
new mux'ed MQTT session stream.
Signed-off-by: Ivan Kozlovic ivan@synadia.com