During compaction the cache may not be loaded completely #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was lmb (active writing). This could lead to the filtered subject state being incorrect. Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
reviewed
Sep 13, 2021
kozlovic
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
LGTM but check my comment about first = last (to me if first == last, then it would mean that there is 1 message of that sequence, while if first = last+1 it can be indication that the first avail seq is "first" but there are currently no message. I think this is how it is in NATS Streaming).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could lead to the filtered subject state being incorrect.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core