Fixed a condition where JetStream assets could be created in multiple leafnode domains. #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… leafnodes. Also added in optional Domain to StreamInfo. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
requested review from
ripienaar,
philpennock,
kozlovic and
matthiashanel
matthiashanel
approved these changes
Sep 14, 2021
Comment on lines
1077
to
+1082
| if accHasJS { | ||
| s.addInJSDenyExport(remote) | ||
| // If we specified a domain do not import by default. | ||
| if hasJSDomain { | ||
| s.addInJSDenyImport(remote) | ||
| } |
There was a problem hiding this comment.
This works, but I have one question about this. Why is it that this is guarded by accHasJs?
If a downstream server (say through another leaf node hop) has no JS enabled, adding a deny should not matter as there is no interest on that end.
If such an account does have JS enabled, then there, presumably we would add the deny. Meaning a deny earlier on shouldn't matter either.
What am I missing?
There was a problem hiding this comment.
We don't need the deny unless the account has JS enabled (not the server), so just trying to keep it small (the deny stuff).
Not sure that answers your question though..
kozlovic
reviewed
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added in optional Domain to StreamInfo.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core