Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor JetStream server settings of 0. #2618

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Honor JetStream server settings of 0. #2618

merged 1 commit into from
Oct 12, 2021

Conversation

derekcollison
Copy link
Member

@derekcollison derekcollison commented Oct 12, 2021

Signed-off-by: Derek Collison derek@nats.io

Resolves: #2599

/cc @nats-io/core

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests need fixing and see comment for embedded users. We may need to have booleans that say "Disable[Memory|File]Store", etc.. if we want to make it work in that case.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printf left, other than that LGTM

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit adf50f2 into main Oct 12, 2021
@derekcollison derekcollison deleted the js-config branch October 12, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetStream resource limits exceeded for server
2 participants