[FIXED] Monitoring: tls configuration not updated on reload #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the http server, we need to provide a TLS configuration. After a config reload, the new TLS config would not be reflected. We had the same issue with Websocket and was fixed with the use of tls.Config.GetConfigForClient API, which makes the TLS handshake to ask for a TLS config. That fix for websocket was simply not applied to the HTTPs monitoring case. I have also fixed some flappers due to the use of localhost instead of 127.0.0.1 (connections possibly would resolve to some IPv6 address that the server would not accept, etc..) Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@matthiashanel I have fixed some tests that tended to flap because of the use of "localhost" since it can resolve to IPv6 (::1 or some other IPv6 local ips) which server may not accept. You will remember that I showed you that once on a google meet because you had a flapper and that was the reason. |
philpennock
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the http server, we need to provide a TLS configuration.
After a config reload, the new TLS config would not be reflected.
We had the same issue with Websocket and was fixed with the use
of tls.Config.GetConfigForClient API, which makes the TLS handshake
to ask for a TLS config. That fix for websocket was simply not applied
to the HTTPs monitoring case.
I have also fixed some flappers due to the use of localhost instead
of 127.0.0.1 (connections possibly would resolve to some IPv6 address
that the server would not accept, etc..)
Signed-off-by: Ivan Kozlovic ivan@synadia.com