There were situations where invalid subjects could be assigned to streams. #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Dec 1, 2021
kozlovic
approved these changes
Dec 1, 2021
|
I confirmed with R.I. that the consumer thing was not reported, he just added it. We could add a test, but he does check now so did not think it would be worth the recovery fixup since never reported. |
|
A consumer in that state will never work. So users probsbly already fixed it themselves. I just wanted to have a better UX. a stream in this situation could have one of n bad subjects and would have worked and we need to avoid the unrecoverable situation where a bad stream has data and then becomes unusable. So we don’t need to bother with consumers imo |
…eams. This will patch them on the fly during recovery. Specifically subjects with leading or trailing spaces and mirror streams with any subjects at all. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
force-pushed
the
bad_stream_subjects
branch
from
f03b250 to
6f5263e
Compare
|
I have rebased from main, resolved the conflicts and push forced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will patch them on the fly during recovery. Specifically subjects with leading or trailing spaces and mirror streams with any subjects at all.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core