Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MaxMsgs and MaxMsgsPer in combination #4253

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

neilalexander
Copy link
Member

This unit test is modelled around issue #4247 and proves that the MaxMsgs and MaxMsgsPer limits are correctly enforced together with DiscardNew and DiscardNewPer.

Signed-off-by: Neil Twigg neil@nats.io

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner June 19, 2023 08:49
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit f7896b4 into main Jun 19, 2023
@derekcollison derekcollison deleted the neil/test4247 branch June 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants