Backport JetStream benchmarks improvements to 2.9.x #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors BenchmarkJetStream(Consume|Publish) and BenchmarkJetStreamKV benchmarks to connect to stream leader for benchmark cases where cluster size is greater than 1. Also, BenchmarkJetStreamKV now only targets a single bucket (B=1). Signed-off-by: Reuben Ninan <reuben@nats.io>
Handle error condition during stream setup that was resulting in failed runs.
Simplify logic and make sure no more than `asyncWindow` messages are ever in-flight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting of JetStream benchmarks that landed in
main(post 2.10.x) anddevbranches back to 2.9.These improvements are to the benchmark code and not specific to 2.10.
Therefore it seems appropriate to back port them, so that benchmarks more accurately compare 2.9 to 2.10 and beyond.
Notice that I cherry-picked the original commits to preserve attribution (and make review easier). However because the back porting can be considered an 'atomic' change, and these have already been reviewed I could also squash into a single commit.
Signed-off-by: Marco Primi marco@synadia.com