Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket: Ensure full writes to compressor #6091

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

neilalexander
Copy link
Member

The cp.Write() call may have been partial and we would not have noticed.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner November 8, 2024 12:45
server/websocket.go Outdated Show resolved Hide resolved
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2b8d891 into main Nov 14, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/wsreaders branch November 14, 2024 15:41
neilalexander added a commit that referenced this pull request Nov 19, 2024
Includes the following:

* #6121
* #6122
* #6126
* #6127
* #6128
* #6091
* #6132
* #6133
* #6135

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants