Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Add jitter for flushing stream state #6220

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[IMPROVED] Add jitter for flushing stream state #6220

merged 1 commit into from
Dec 5, 2024

Conversation

MauriceVanVeen
Copy link
Member

flushStreamStateLoop would always run on the same interval for each and every stream. Introduce jitter to spread out after restarts.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
Add jitter for flushing stream state
455808b 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 5, 2024 12:41
derekcollison
derekcollison approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e59bb19 into main Dec 5, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/flush-stream-state-jitter branch December 5, 2024 19:29
@wallyqs wallyqs changed the title Add jitter for flushing stream state [IMPROVED] Add jitter for flushing stream state Dec 5, 2024
@wallyqs wallyqs mentioned this pull request Dec 5, 2024
Merged
wallyqs added a commit that referenced this pull request Dec 5, 2024
@wallyqs
Cherry-picks for 2.10.23-RC.11 (#6222)
a6872a4 
- #6213
- #6215
- #6212
- #6214
- #6219
- #6220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @derekcollison