Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRG: Only continue if aligned with pindex/pterm #6271

Merged
merged 1 commit into from
Dec 17, 2024
Merged

NRG: Only continue if aligned with pindex/pterm #6271

merged 1 commit into from
Dec 17, 2024

Conversation

MauriceVanVeen
Copy link
Member

If truncation fails we would spin on retrying. Now only continue if pindex/pterm are aligned, otherwise responds non-success to the leader.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
NRG: Only continue if aligned with pindex/pterm
39ebc97 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 17, 2024 11:45
neilalexander
neilalexander approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit d323e23 into main Dec 17, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/raft-truncate-continue branch December 17, 2024 14:17
@neilalexander neilalexander mentioned this pull request Dec 17, 2024
Merged
neilalexander added a commit that referenced this pull request Dec 17, 2024
@neilalexander
Cherry-picks for 2.10.24 (#6273)
e031e65 
Includes the following:

- #6269
- #6271

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauriceVanVeen @neilalexander @derekcollison