Add account name tag to monitoring endpoints #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supersedes #5173 since it introduced a redundant field `LogicalName` on `Account` with the existing field `nameTag`. The endpoints that are currently covered include: - /accountz - /accstatz - /connz - /subsz - /jsz The endpoints: - /routez - /gatewayz - /leafz also contain account metadata, but has not been implemented yet. Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
bruth
commented
Jan 2, 2025
| } | ||
| a.mu.RLock() | ||
| name := a.Name | ||
| a.mu.RUnlock() | ||
| return name | ||
| } | ||
|
|
||
| // getNameTag will return the name tag or the account name if not set. | ||
| func (a *Account) getNameTag() string { |
There was a problem hiding this comment.
In the context of monitoring and operator mode, this PR makes the assumption that if an explicit JWT name (not the subject) is not set, the name tag will default to the JWT which equates to the account name.
This may seem redundant, but the purpose is that its a consistent way to report on a standard value regardless if the name is set.
Signed-off-by: Byron Ruth <byron@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #5173 since it introduced a redundant field
LogicalNameonAccountwith the existing fieldnameTag.The endpoints that are currently covered include:
The following endpoints also contain account metadata, but have not been implemented yet.