Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.11] Make RPMs and DEBs reproducible #6359

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[v2.11] Make RPMs and DEBs reproducible #6359

merged 2 commits into from
Jan 23, 2025

Conversation

alexbozhenko
Copy link
Contributor

@alexbozhenko alexbozhenko commented Jan 10, 2025 •
edited
Loading

Similar to #6299
Make packages set mtime to commitdate.

Upgrade goreleaser to the latest 2.6.1, which includes the feature used in this PR: goreleaser/goreleaser#5392

go install github.com/goreleaser/goreleaser/v2@v2.6.1
goreleaser release --snapshot --clean -f .goreleaser.yml
mv dist/ ~/tmp/dist_before
goreleaser release --snapshot --clean -f .goreleaser.yml 

# now, all the artifacts of the two builds are exactly the same. Only sbom files are different(because those include timestamps)
vimdiff dist/SHA256SUMS ~/tmp/dist_before/SHA256SUMS

image

Signed-off-by: Alex Bozhenko alex@synadia.com

@neilalexander
Copy link
Member

Is this still in-flight?

@neilalexander neilalexander changed the title Make RPMs ans DEBs reproducible Make RPMs and DEBs reproducible Jan 22, 2025
@alexbozhenko
upd goreleaser version
3ed94c2 
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
@alexbozhenko alexbozhenko marked this pull request as ready for review January 22, 2025 18:32
@alexbozhenko alexbozhenko requested a review from a team as a code owner January 22, 2025 18:32
@alexbozhenko
Copy link
Contributor Author

@neilalexander it's ready for review now.

wallyqs
wallyqs approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs changed the title Make RPMs and DEBs reproducible [v2.11] Make RPMs and DEBs reproducible Jan 22, 2025
neilalexander
neilalexander approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit dec670a into nats-io:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexbozhenko @neilalexander @wallyqs @derekcollison