Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for 2.10.25-RC.3 #6384

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Cherry-picks for 2.10.25-RC.3 #6384

merged 8 commits into from
Jan 22, 2025

Conversation

neilalexander and others added 3 commits January 20, 2025 12:16
After a drain this would have been misreporting, as we did not remove
drained entries from the `apiInflight` count.

Signed-off-by: Neil Twigg <neil@nats.io>
If a cluster has leafnode connections and each have the same queue
group, the loss of a leafnode connection could cause the server
in the "hub" cluster to drop interest across a gateway for this
queue group.

The issue is fixed by properly accounting for all queue sub and
unsub in the server gateway interest map.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 20, 2025 12:18
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deem0n and others added 5 commits January 21, 2025 15:47
Signed-off-by: Dmitry Dorofeev <dima@yasp.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Currently, there are scenarios where NATS JetStream may encounter
permission errors when file system goes into read only mode, which can
lead to an inconsistent state. In such cases, the system continues to
allow publishing messages by resetting stream state, leading to a
misaligned consumer stream sequence.

This PR introduces changes to gracefully handle these permission errors
and prevent NATS from continuing in an inconsistent state when:

- Flushing stream state to disk
- Deleting expired messages on startup
- Creating new block for messages
After this PR, If NATS is running in non-clustered mode, the user will
be unable to issue write requests until the issue is resolved. In
clustered mode, only the affected node will stop accepting requests,
while the system will continue to function as long as the required
quorum remains healthy.

PR potentially fixes : #6211 which leads to consumer sequence reaching
higher than stream sequence.

Signed-off-by: Sourabh Agrawal <souravagrawal1111@gmail.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit d198cac into release/v2.10.25 Jan 22, 2025
5 checks passed
@neilalexander neilalexander deleted the neil/21025rc3 branch January 22, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants