[FIXED] (2.11) Upgrade path for deterministic clustered dedupe #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
changed the title
derekcollison
deleted the
maurice/deterministic-clustered-dedupe-upgrade
branch
MauriceVanVeen
added a commit
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
derekcollison
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of #6415 we have a deterministic way of de-duplication such that leader changes are no issue as well as never returning a zero-sequence or duplicate conflict error.
However, during an upgrade this could result in stream desync. This was due to a replica accepting anything the leader tells it to do, ignoring if the message is a duplicate. So if the leader running the new version would propose multiple duplicate messages (which is correct under the new behavior), the old version would ingest all messages instead of only the first.
This PR fixes that by having the leader only do these types of proposals if all servers within the group support it. Otherwise it falls back to the previous implementation.
Signed-off-by: Maurice van Veen github@mauricevanveen.com