Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Stream ingest after JWT exports/imports update #6498

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

MauriceVanVeen
Copy link
Member

Messages that are exported/imported can be published on an account that has an export, and ingested into a stream in an account that imports it.

This would not work as expected if the stream existed prior to a server restart, and exports/imports would be updated after.

  • If exports/imports are added which should allow the stream to ingest, these messages would not be received by the stream.
  • If exports/imports are removed which should stop message flow to the stream, the stream would keep receiving messages.

Once the server was restarted again, the exports/imports would be respected.

The issue was that the internal JetStream client that's used for the stream was added to the account before its a.clients map was initialized. So once the exports/imports were updated, these clients/subs would not be reloaded.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner February 11, 2025 15:15
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit ffa2227 into main Feb 11, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/jwt-update-stream-ingest branch February 11, 2025 15:40
neilalexander added a commit that referenced this pull request Feb 12, 2025
Includes the following:

- #6492
- #6494
- #6498
- #6500
- #6499
- #6502

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants