[FIXED] Windows Service: do not force usage of syslog #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting as a Windows Service, we were creating a syslog to possibly log the failure to start. But users running without admin privileges would be unable to use the service since the server would fail to create the event log entry. So create the syslog only if explicit set (-syslog <bool> option) or if no logfile has been specified. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
This was reported through Google mailing list and was confirmed to be addressing the issue: https://groups.google.com/d/msg/natsio/d0Jk3N7iqZ8/Hcds3p5LAQAJ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting as a Windows Service, we were creating a syslog to
possibly log the failure to start. But users running without
admin privileges would be unable to use the service since the
server would fail to create the event log entry.
So create the syslog only if explicit set (-syslog option)
or if no logfile has been specified.
Signed-off-by: Ivan Kozlovic ivan@synadia.com