Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] FileStore: index file may be recreated with wrong offsets #1087

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

kozlovic
Copy link
Member

This could happen if recovery of an index does not have matching
information with the last message in corresponding ".dat" file.
In that case, the server wipes the index file and recreate it
based on the data file. However, the offset was not reset, which
means that the index file would contain wrong offsets.

Resolves #1086

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic kozlovic marked this pull request as draft September 14, 2020 23:52
This could happen if recovery of an index does not have matching
information with the last message in corresponding ".dat" file.
In that case, the server wipes the index file and recreate it
based on the data file. However, the offset was not reset, which
means that the index file would contain wrong offsets.

Resolves #1086

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 91.715% when pulling 20db05d on fix_1086 into 4208132 on master.

@kozlovic kozlovic marked this pull request as ready for review September 15, 2020 00:07
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 363954a into master Sep 15, 2020
@kozlovic kozlovic deleted the fix_1086 branch September 15, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileStore: possibly create index with wrong offsets after data/index mismatch
3 participants