[IMPROVED] Bulk insert of messages #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new configuration `bulk_insert_limit` switches the server from the current insertion of messages within a SQL transaction, to an "INSERT INTO MESSAGES () VALUES (),(),..." which can speed up performance by several folds. The server still may perform regular insert within transaction if the limit is deemed too low. This new configuration parameter is not enabled by default. It needs to be explicitly set, either in configuration file or from command line `--sql_bulk_insert_limit <number here>`. Resolves #1132 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
aricart
approved these changes
Jan 8, 2021
kozlovic
added a commit
that referenced
this pull request
Jan 9, 2021
This relates to #1140 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new configuration
bulk_insert_limitswitches the server fromthe current insertion of messages within a SQL transaction, to
an "INSERT INTO MESSAGES () VALUES (),(),..." which can speed up
performance by several folds.
The server still may perform regular insert within transaction
if the limit is deemed too low.
This new configuration parameter is not enabled by default. It
needs to be explicitly set, either in configuration file or
from command line
--sql_bulk_insert_limit <number here>.Resolves #1132
Signed-off-by: Ivan Kozlovic ivan@synadia.com