[FIXED] Clustering: message store not flushed on followers #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the SQLStore, this would cause messages to be accumulated in write cache causing memory growth and no message stored in the DB until the follower shutsdown or become leader. Resolves #846 Also made server tests skip SQL specific tests if running tests with `-sql=false` for users that don't have/want to setup an SQL server. Resolves #845 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the SQLStore, this would cause messages to be accumulated
in write cache causing memory growth and no message stored in the
DB until the follower shutsdown or become leader.
Resolves #846
Also made server tests skip SQL specific tests if running tests
with
-sql=falsefor users that don't have/want to setup anSQL server.
Resolves #845
Signed-off-by: Ivan Kozlovic ivan@synadia.com