[FIXED] Redelivery of unack'ed msgs of leaving queue member #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a queue member has unacknowledged messages and is leaving the group, these messages are supposed to be immediately redelivered to existing queue members. However, if a target member had unack'ed messages of a sequence lower than the reassigned messages these reassigned messages would not be redelivered until after the AckWait. The issue was introduced in PR #729 with the incorrect change in ordering algo for the messages that should expire. Resolves #869 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a queue member has unacknowledged messages and is leaving the
group, these messages are supposed to be immediately redelivered
to existing queue members. However, if a target member had unack'ed
messages of a sequence lower than the reassigned messages these
reassigned messages would not be redelivered until after the AckWait.
The issue was introduced in PR #729
with the incorrect change in ordering algo for the messages that
should expire.
Resolves #869
Signed-off-by: Ivan Kozlovic ivan@synadia.com