[ADDED] FileStore: read ahead capability #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new option `file_read_buffer_size` is added and defaults to 2MB. If not set to 0, when a message is read from disk, the store will actually read the following messages, up to that buffer size, and add them to the internal cache (which already existed and has a default TTL of 1sec). This will speed up lookups of following messages since they are likely to be in the cache. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Still reading the indexes from file, but in a single I/O operation. Tried to have indexes in memory to avoid that read and did not see a dramatic advantage (at least in a simple test). Will revisit that later. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option
file_read_buffer_sizeis added and defaults to 2MB.If not set to 0, when a message is read from disk, the store will
actually read the following messages, up to that buffer size, and
add them to the internal cache (which already existed and has a
default TTL of 1sec).
This will speed up lookups of following messages since they are
likely to be in the cache.
Signed-off-by: Ivan Kozlovic ivan@synadia.com