[ADDED] FileStore: auto sync interval #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to have the store auto flush/sync stores at regular interval. This can be useful if one wants to disable sync at every Flush() but still wants to have files being sync'ed from time to time. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this pull request
Jul 22, 2019
The original implementation was having a central timer routine that would go through the list of channels (interface) and cast them to FileMsgStore and FileSubStore to invoke the stores' autoSync() functions. However, with stores that wrap a FileStore instance (such as RAFT or Crypto store), that would cause a panic since the casting would fail. Alternative fix would have been for FileStore to maintain a separate map of actual File[Msg/Sub]Store, but I chose instead to move the call to autoSync() into the Msg/Sub stores themselves. Relates to #882 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this pull request
Jul 22, 2019
The original implementation was having a central timer routine that would go through the list of channels (interface) and cast them to FileMsgStore and FileSubStore to invoke the stores' autoSync() functions. However, with stores that wrap a FileStore instance (such as RAFT or Crypto store), that would cause a panic since the casting would fail. Alternative fix would have been for FileStore to maintain a separate map of actual File[Msg/Sub]Store, but I chose instead to move the call to autoSync() into the Msg/Sub stores themselves. Relates to #882 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this pull request
Jul 22, 2019
The original implementation was having a central timer routine that would go through the list of channels (interface) and cast them to FileMsgStore and FileSubStore to invoke the stores' autoSync() functions. However, with stores that wrap a FileStore instance (such as RAFT or Crypto store), that would cause a panic since the casting would fail. Alternative fix would have been for FileStore to maintain a separate map of actual File[Msg/Sub]Store, but I chose instead to move the call to autoSync() into the Msg/Sub stores themselves. Relates to #882 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to have the store auto flush/sync stores at regular
interval. This can be useful if one wants to disable sync at every
Flush() but still wants to have files being sync'ed from time to
time.
Signed-off-by: Ivan Kozlovic ivan@synadia.com