-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#52 support refreshing N times #56
Merged
wallyqs
merged 17 commits into
nats-io:main
from
dsidirop:ksidirop/NTOP-0052-support-refreshing-N-times
Feb 9, 2022
Merged
#52 support refreshing N times #56
wallyqs
merged 17 commits into
nats-io:main
from
dsidirop:ksidirop/NTOP-0052-support-refreshing-N-times
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able - the if-else structure was not really needed and it has been simplified to use plain 'ifs' - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…inted in raw bytes
…y-raw-bytes ksidirop/NTOP 0053 flag to display raw bytes
… t.Run() instead of raw tests
…y-raw-bytes clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
… t.Run() instead of raw tests
…idirop/NTOP-0053-flag-to-display-raw-bytes
…y-raw-bytes nats-io#53 new cli-flag '-b' to display raw bytes
- consolidate 1024-related constants used in Psize() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement - the if-else structure was not really needed and it has been simplified to use plain 'ifs' - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective - neutral cleanups in Psize() to make it more readable - refactor the test harness to have it employ t.Run() instead of raw tests
…tes-flag ksidirop/NTOP 0053 support raw bytes flag
* 'main' of github.com:nats-io/nats-top: Add Raw bytes toggle (nats-io#55) nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
…each redraw with this change we can support the new '-r N' flag to exit upon refreshing N times
…r of times nats-top should refresh nats-stats before exiting
wallyqs
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dsidirop
pushed a commit
to dsidirop/nats-top
that referenced
this pull request
Feb 9, 2022
…-0057-new-cli-flag-save-single-snapshot-to-file * 'main' of github.com:nats-io/nats-top: nats-io#52 support refreshing N times (nats-io#56) # Conflicts: # nats-top.go # readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.