Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 support refreshing N times #56

Merged

Conversation

dsidirop
Copy link
Contributor

@dsidirop dsidirop commented Feb 8, 2022

No description provided.

dsidirop and others added 17 commits February 7, 2022 00:50
…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able

  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…y-raw-bytes

ksidirop/NTOP 0053 flag to display raw bytes
…y-raw-bytes

clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
…y-raw-bytes

nats-io#53 new cli-flag '-b' to display raw bytes
  - consolidate 1024-related constants used in Psize() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
  - neutral cleanups in Psize() to make it more readable
  - refactor the test harness to have it employ t.Run() instead of raw tests
…tes-flag

ksidirop/NTOP 0053 support raw bytes flag
* 'main' of github.com:nats-io/nats-top:
  Add Raw bytes toggle (nats-io#55)
  nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
…each redraw

  with this change we can support the new '-r N' flag to exit upon refreshing N times
…r of times nats-top should refresh nats-stats before exiting
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wallyqs wallyqs merged commit d8fa604 into nats-io:main Feb 9, 2022
dsidirop pushed a commit to dsidirop/nats-top that referenced this pull request Feb 9, 2022
…-0057-new-cli-flag-save-single-snapshot-to-file

* 'main' of github.com:nats-io/nats-top:
  nats-io#52 support refreshing N times (nats-io#56)

# Conflicts:
#	nats-top.go
#	readme.md
@dsidirop dsidirop deleted the ksidirop/NTOP-0052-support-refreshing-N-times branch February 13, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants