Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#59 new cli flag -l for column-separation in output textfile (to generate csvs etc) #60

Merged

Conversation

dsidirop
Copy link
Contributor

No description provided.

dsidirop and others added 30 commits February 7, 2022 00:50
…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able

  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…y-raw-bytes

ksidirop/NTOP 0053 flag to display raw bytes
…y-raw-bytes

clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
…y-raw-bytes

nats-io#53 new cli-flag '-b' to display raw bytes
  - consolidate 1024-related constants used in Psize() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
  - neutral cleanups in Psize() to make it more readable
  - refactor the test harness to have it employ t.Run() instead of raw tests
…tes-flag

ksidirop/NTOP 0053 support raw bytes flag
* 'main' of github.com:nats-io/nats-top:
  Add Raw bytes toggle (nats-io#55)
  nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
…each redraw

  with this change we can support the new '-r N' flag to exit upon refreshing N times
…r of times nats-top should refresh nats-stats before exiting
…hing-N-times

Ksidirop/ntop 0052 support refreshing n times
…ave-single-snapshot-to-file

$57 new cli flag save single snapshot to file
…ave-single-snapshot-to-file

feat (cli flag '-o -'): passing '-o -' now prints the snapshot to the…
…s to usage() with calls to fmt.Fprintf(os.stderr, ...)

   this fix allows the usage message to be actually printed (old was: log.Fatalf(...) would cause the program to os.exit(1) before
   the usage message could actually be printed)
@wallyqs wallyqs merged commit 696b065 into nats-io:main Feb 16, 2022
@dsidirop dsidirop deleted the ksidirop/NTOP-59-new-cli-flag-format-snapshot-csv branch May 13, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants