Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the never-implemented schema #657

Merged
merged 1 commit into from
May 22, 2023

Conversation

levb
Copy link
Collaborator

@levb levb commented May 22, 2023

I never finished the schema implementation, but thankfully it's been removed, see nats-io/nats-architecture-and-design#220 and nats-io/nats.go#1270.

This PR removes it from the C implementation.

@levb levb requested review from kozlovic and piotrpio May 22, 2023 12:54
Copy link

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit d6f3747 into lev-microservice-proto May 22, 2023
@levb levb deleted the lev-microservice-proto-noschema branch June 3, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants