Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI only] Skip codecov for forks until they resolve tokenless uploads… #768

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

levb
Copy link
Collaborator

@levb levb commented Jun 21, 2024

#763 is currently failing to upload codecov reports, because of an issue in codecov. Until they resolve it, disable codecov for PRs from forked repos.

@levb levb requested a review from kozlovic June 21, 2024 18:09
@levb levb marked this pull request as ready for review June 21, 2024 18:09
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (1553d4a) to head (311b54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   68.71%   68.71%           
=======================================
  Files          39       39           
  Lines       15207    15207           
  Branches     3143     3143           
=======================================
  Hits        10449    10449           
- Misses       1700     1701    +1     
+ Partials     3058     3057    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you have a way to test that? I guess the PR that you refer to that is failing because of that should be updated to see if that would work.

@levb
Copy link
Collaborator Author

levb commented Jun 22, 2024

No I don't have a way of testing this, short of maybe you cutting a PR to my fork from your fork. This PR itself is the test that it still fires on our repo.

@kozlovic
Copy link
Member

@levb I don't use forks, that's why I asked if the PR that demonstrated this issue (PR #763) could not add this one line fix to see if that solves the issue.

Co-authored-by: mtmk <ziya@suzen.net>
@levb levb merged commit 048621b into main Jul 15, 2024
18 checks passed
@levb levb deleted the lev-disable-codecov-forks branch July 15, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants