Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterator fixes #190

Merged
merged 4 commits into from
Aug 31, 2021
Merged

iterator fixes #190

merged 4 commits into from
Aug 31, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Aug 27, 2021

while writing some tests for KV changes noticed that some unexpected breaks from iterators were leaving behind subscriptions - this PR solves those problems

…turn, now these are properly detected, and delegate to call unsubscribe on the subscription.

[FIX] linter warnings
@aricart aricart requested a review from kozlovic August 30, 2021 17:07
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit ddf5a41 into main Aug 31, 2021
@aricart aricart deleted the iter-fixes branch August 31, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants