FIX partial frames during connect's peek of the info block #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toLen, which returned -1. In such a case, it was possible to attempt processing a frame that wasn't complete. This only happened during connect.
kozlovic
approved these changes
Sep 27, 2021
| } | ||
|
|
||
| export function extractProtocolMessage(a: Uint8Array): string { | ||
| // protocol messages are ascii, so Uint8Array | ||
| const len = protoLen(a); | ||
| if (len) { | ||
| if (len > 0) { |
There was a problem hiding this comment.
Since you changed from -1 to 0, the test if (len) { would then become valid, but I am ok being explicit here.
There was a problem hiding this comment.
yeap going to keep it that way - at some point I believe the code returned 0, and then changed (this was used by the protocol parser before. Testing for what we are looking for is always a good thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix]
extractProtocolMessage, was loosely testing the result fromprotoLen, which returned -1. In such a case, it was possible to attempt processing a frame that wasn't complete. This only happened during connect.